EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48070 )
Change subject: mb/google/brya: Set UART console
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48070/2/src/mainboard/google/brya/K...
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/48070/2/src/mainboard/google/brya/K...
PS2, Line 6: select SOC_INTEL_ALDERLAKE
include `select INTEL_LPSS_UART_FOR_CONSOLE` as well?
yes, but why don't select this in soc. Interesting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48070
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e334fee1adcd79d058b7ab07127f8ecf1735202
Gerrit-Change-Number: 48070
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Dec 2020 04:12:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment