Attention is currently required from: Hung-Te Lin, jason-ch chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74064 )
Change subject: soc/mediatek/mt8188: set pin drive strength to 8mA for NOR
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74064/comment/3383ea42_14d3236a
PS5, Line 7: set
Set
File src/soc/mediatek/mt8188/spi.c:
https://review.coreboot.org/c/coreboot/+/74064/comment/9cd5e995_99470cba
PS5, Line 111: BIOS_WARNING
Shouldn't this be an error?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74064
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If8344449f5b34cefcaaee6936e94f7f669c7148b
Gerrit-Change-Number: 74064
Gerrit-PatchSet: 5
Gerrit-Owner: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: jason-ch chen
Jason-ch.Chen@mediatek.com
Gerrit-Comment-Date: Wed, 05 Apr 2023 15:16:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment