HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29990 )
Change subject: sb/{bd82x6x,i82801gx,ibexpeak,lynxpoint}: Use BIOS_CNTL macro ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29990/1/src/southbridge/intel/i82801gx/lpc.c File src/southbridge/intel/i82801gx/lpc.c:
https://review.coreboot.org/#/c/29990/1/src/southbridge/intel/i82801gx/lpc.c... PS1, Line 358: #if TEST_SMM_FLASH_LOCKDOWN
is this dead code ?
indeed, TEST_SMM_FLASH_LOCKDOWN is defined as zero. for my understanding, this is used for test/debug purpose.
I can remove it if there is no objection.