Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43061 )
Change subject: soc/intel/tigerlake: Update Tiger Lake SA IDs
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43061/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43061/2//COMMIT_MSG@12
PS2, Line 12: 9A02h
I did not find any code change in your CL for 9a02. Are we missing something here ?
https://review.coreboot.org/c/coreboot/+/43061/2/src/include/device/pci_ids....
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/43061/2/src/include/device/pci_ids....
PS2, Line 3527: 0x9A10
any reason for removing this 0x9A10 entry which is for Y segment SKU ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43061
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9d9c9ac3bf39582b0da610e6ef912031939c763
Gerrit-Change-Number: 43061
Gerrit-PatchSet: 2
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Jul 2020 11:41:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment