Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43153 )
Change subject: mb/google/dedede: Add Goodix touchscreen ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 77: 120
- T3 is >= 10ms in the spec between Reset and Report_EN? […]
There does seem to be a TOUCH_RPT_EN, so the stop_gpio should be added. Need to confirm it actually goes to the chip. Will do that.
Then T1 is 12ms, T3 is 12ms, and then stop_delay can be 110.
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 78: 3
1ms for T2 and T3 in the spec so do we play safe here?
Yes, though it seems like 2 should be fine here, so I'll change to that, and add stop_off_delay_ms of 2 as well.
https://review.coreboot.org/c/coreboot/+/43153/2/src/mainboard/google/dedede... PS2, Line 80: 12
The GT7375P Programming Guide Rev 0. […]
I noticed most of the other users of GDIX0000 seem to have this padding. If we're feeling adventurous we could start with 10 and see if problems come up.