Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48201 )
Change subject: Makefile.inc: Fix empty output when processing C struct files in CBFS ......................................................................
Patch Set 9:
(7 comments)
https://review.coreboot.org/c/coreboot/+/48201/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48201/6//COMMIT_MSG@18 PS6, Line 18: ** $$(@) == $(2) **
$1 contains the name of source file.
Done
https://review.coreboot.org/c/coreboot/+/48201/6//COMMIT_MSG@19 PS6, Line 19: $$(@)
$1
Done
https://review.coreboot.org/c/coreboot/+/48201/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48201/9//COMMIT_MSG@11 PS9, Line 11: directly Line too long.
https://review.coreboot.org/c/coreboot/+/48201/9//COMMIT_MSG@13 PS9, Line 13: $(@)=$2 is actually a temporary file Isn't this already mentioned in the first paragraph? Also, isn't $(@) an empty string?
https://review.coreboot.org/c/coreboot/+/48201/1/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48201/1/Makefile.inc@339 PS1, Line 339: $$(<) -->
then you should describe that in the commit description as well, or put that into a separate change.
Done
https://review.coreboot.org/c/coreboot/+/48201/5/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48201/5/Makefile.inc@336 PS5, Line 336:
ok, agree it.
Done
https://review.coreboot.org/c/coreboot/+/48201/5/Makefile.inc@336 PS5, Line 336: <
So maybe just use $(1) instead? It may be more clear than $@ and $< given the order was reversed in […]
Done