Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33168 )
Change subject: mediatek/mt8183: set vproc12 voltage correctly ......................................................................
mediatek/mt8183: set vproc12 voltage correctly
The correct address for vproc12 register of sw mode is 0x1426 instead of 0x140a.
BUG=b:80501386 BRANCH=none Test=Boots correctly on Kukui and see that regulator is not stuck to 1.05V anymore: grep vproc12 /sys/kernel/debug/regulator/regulator_summary
Change-Id: I13867b11c44019875e0ed607343197950a3b38b2 Signed-off-by: Hsin-Hsiung Wang hsin-hsiung.wang@mediatek.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33168 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Nicolas Boichat drinkcat@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8183/mt6358.c 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nicolas Boichat: Looks good to me, but someone else must approve Hung-Te Lin: Looks good to me, approved hsin-hsiung wang: Looks good to me, but someone else must approve
diff --git a/src/soc/mediatek/mt8183/mt6358.c b/src/soc/mediatek/mt8183/mt6358.c index ea4274f..53d2a43 100644 --- a/src/soc/mediatek/mt8183/mt6358.c +++ b/src/soc/mediatek/mt8183/mt6358.c @@ -497,8 +497,10 @@ {0x1B6C, 0x6, 0x6, 0},
/* Vproc11/Vproc12 to 1.05V */ + /* [6:0]: RG_BUCK_VPROC11_VOSEL */ {0x13a6, 0x58, 0x7F, 0}, - {0x140a, 0x58, 0x7F, 0}, + /* [6:0]: RG_BUCK_VPROC12_VOSEL */ + {0x1426, 0x58, 0x7F, 0}, };
static struct pmic_setting lp_setting[] = {