[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Make CpuMpPpi implementation default for ICL

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36839 )

Change subject: soc/intel/icelake: Make CpuMpPpi implementation default for ICL
......................................................................

Patch Set 3:
> Patch Set 3:
>
> Sorry for being late. But I don't follow the argumentation here.
>
> If `SkipMpInit` is only deprecated, i.e. not removed yet, why is it
> suddenly mandatory to set it to 0? Is `SkipMpInit` broken in current
> ICL FSP? Before this change, did something break if
> CONFIG_USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
> was deselected?
>
> Also, the commit message doesn't match the change. It was already
> the default. This change enforces it.

i don't have any plan to uprev the ICL headers in recent time hence just made the provision for other platform to remove SKipMpInit. SKipMpInit has removed from all other ICL onward platform and selecting anything else that MP_PPI won't help to meet the all CPU feature programming as documented.