Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48286/15/src/soc/intel/common/block...
File src/soc/intel/common/block/cpu/car/exit_car.S:
https://review.coreboot.org/c/coreboot/+/48286/15/src/soc/intel/common/block...
PS15, Line 135: ebx
shouldn't this be eax?, ebx is way size
[Had discussion with Tim, to make the CAR exit code simpler, we planned to add Kconfig fields for reset default values for QOS_MASK & SF_MASK MSRs. Use them to reset the values in CAR exit code. Making this change now.]
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabf7f387fb5887aca10158788599452c3f2df7e8
Gerrit-Change-Number: 48286
Gerrit-PatchSet: 15
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Dec 2020 21:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment