build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28697 )
Change subject: drivers/spi/winbond: Add function to lock flash's status register ......................................................................
Patch Set 4:
(8 comments)
https://review.coreboot.org/#/c/28697/4/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c:
https://review.coreboot.org/#/c/28697/4/src/drivers/spi/winbond.c@540 PS4, Line 540: const enum spi_flash_status_reg_lockdown mode, code indent should use tabs where possible
https://review.coreboot.org/#/c/28697/4/src/drivers/spi/winbond.c@541 PS4, Line 541: const bool non_volatile) code indent should use tabs where possible
https://review.coreboot.org/#/c/28697/4/src/drivers/spi/winbond.c@555 PS4, Line 555: val = (union status_reg1_bp3){ .srp0 = !!(mode & 1) }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/4/src/drivers/spi/winbond.c@556 PS4, Line 556: mask = (union status_reg1_bp3){ .srp0 = 1 }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/4/src/drivers/spi/winbond.c@558 PS4, Line 558: val = (union status_reg1_bp4){ .srp0 = !!(mode & 1) }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/4/src/drivers/spi/winbond.c@559 PS4, Line 559: mask = (union status_reg1_bp4){ .srp0 = 1 }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/4/src/drivers/spi/winbond.c@566 PS4, Line 566: val = (union status_reg2){ .srp1 = !!(mode & 2) }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/4/src/drivers/spi/winbond.c@567 PS4, Line 567: mask = (union status_reg2){ .srp1 = 1 }.u; space required after that close brace '}'