13 Jun
2019
13 Jun
'19
8:44 p.m.
Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33411 )
Change subject: inteltool: add support for CannonPoint-LP ......................................................................
Patch Set 2: -Code-Review
Reading through this one more time, it looks like the GPIO settings are wrong for the GPP_F block. There should be CNVi (GPP_F0 and GPP_F4 through GPP_F9) and EMMC lines (GPP_F11 through GPP_F22) that I do not see.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33411
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3593ffe7d997261e9b7189ec4083cf75aaf3cf9
Gerrit-Change-Number: 33411
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Jeremy Soller jackpot51@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Jun 2019 18:44:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment