Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, Patrick Rudolph, Raul Rangel.
Maximilian Brune has posted comments on this change by Fred Reitberger. ( https://review.coreboot.org/c/coreboot/+/68122?usp=email )
Change subject: soc/amd/common: Support sbin ucode files
......................................................................
Patch Set 9:
(1 comment)
File src/soc/amd/common/block/cpu/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/68122/comment/3e091794_c75a824f?usp... :
PS9, Line 32: # if there is both a sbin and bin microcode only include the bin one to keep the old behaviour
When I last worked on this, the releases would be in '. […]
This only covers the case if there is both an sbin and bin (like currently in mendocino). In this case I chose to prefer the bin over sbin, because that would keep the current behaviour on mendocino. But on newer releases I assume we will only get sbin microcodes. In that case the sbin microcode will be used (since there is no identical bin microcode present).
I just wanted to make sure that downstream (for example in case of google downstream forks that include the binaries) doesn't suddenly use an sbin instead of bin in case both are present.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68122?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I29768ea19543bdc76662e687f59bf31b76f555ae
Gerrit-Change-Number: 68122
Gerrit-PatchSet: 9
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 04 Feb 2025 01:26:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com