Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35546 )
Change subject: soc/intel/common/block/cse: Minor clean up some late comments
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35546/14/src/soc/intel/common/block...
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35546/14/src/soc/intel/common/block...
PS14, Line 47: SOC_INTEL_APOLLOLAKE
Ideally, I would prefer having the definition of me_hfsts1 in SoC specific code to avoid polluting c […]
In fact, I think I see at least one more deviation for TGL. Can you please check this across platforms to ensure if it is really a good idea to have this definition in common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35546
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7ea6043d7b5473d0c16e83d7b2d4b620c125652
Gerrit-Change-Number: 35546
Gerrit-PatchSet: 14
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
riz.pro@gmail.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 05 Jan 2020 18:49:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment