Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39359 )
Change subject: soc/intel/tigerlake: Save DIMM info by available nodes
......................................................................
Patch Set 2:
Patch Set 2:
(2 comments)
+Karthik - Most likely this is not going to work for JSL.
Is that a problem? This code change is in a "tigerlake" directory. Of course, we can talk about whether the code can or cannot be shared with other platforms in the future, but I do not take this comment as challenging whether it is OK to commit as is.
Right now, jasperlake is actually using "tigerlake" directory. So, it does impact jasperlake boards. But I think this is most likely already broken for jasperlake, so your change probably doesn't break it more. I have added Karthik as FYI here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I951ea94c280b7dd5b67f320a264d13fca82a4596
Gerrit-Change-Number: 39359
Gerrit-PatchSet: 2
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Mon, 09 Mar 2020 23:11:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment