Attention is currently required from: Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55185 )
Change subject: drivers/generic/ioapic: Use arch/x86/ioapic
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/drivers/generic/ioapic/ioapic.c:
https://review.coreboot.org/c/coreboot/+/55185/comment/899c61cb_5f8024db
PS3, Line 17: config->enable_virtual_wire);
I doubt if irq_on_fsb is worth keeping in devicetree. Usage is bound to CPU model AFAICS. […]
The only boards that set `irq_on_fsb` are gm45 boards and samsung/lumpy. I don't get the point of CB:1462 (commit message body does not exist)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfaf6693288005463e45831fe100a5052e97cf2f
Gerrit-Change-Number: 55185
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 06 Jun 2021 17:47:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment