Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40437 )
Change subject: intel/stm: Place resource list right below MSEG ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40437/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40437/1//COMMIT_MSG@9 PS1, Line 9: CL 38765
Apologies if I wasn't clear. What I meant is that the commit message should say "CB:38765" instead.
… so Gerrit marks them up as links. CL:… goes to Chromium OS, so CB: is correct here.
https://review.coreboot.org/c/coreboot/+/40437/1/src/cpu/x86/smm/smm_module_... File src/cpu/x86/smm/smm_module_loader.c:
https://review.coreboot.org/c/coreboot/+/40437/1/src/cpu/x86/smm/smm_module_... PS1, Line 361: base -= CONFIG_MSEG_SIZE + CONFIG_BIOS_RESOURCE_LIST_SIZE; Without background, the removal of the else branch is not obvious.