Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )
Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded...
File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded...
PS11, Line 23: select FW_CONFIG
: select FW_CONFIG_SOURCE_CHROMEEC_CBI
This can be moved under BOARD_GOOGLE_BASEBOARD_DEDEDE in Kconfig file since we will use FW_CONFIG fo […]
Done
https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded...
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded...
PS11, Line 2: field TABLETMODE 10
FW_CONFIG bit 10 is used to identify tablet mode for all of dedede. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcd498021e63d0a172c71c3d94b60b3a25973467
Gerrit-Change-Number: 44661
Gerrit-PatchSet: 12
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 09 Sep 2020 08:08:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment