Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44919 )
Change subject: mb/google/volteer: Enable USB4 retimer driver
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44919/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44919/2/src/mainboard/google/voltee...
PS2, Line 396: ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H10)
my reading of the BB spec is that this is a signal to keep the chip from
going to sleep. i'm not sure why we unconditionally assert this in
gpio.c now. also, it's active high.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I166bc477f94c159bb411620a6bf77b5d1f194fb2
Gerrit-Change-Number: 44919
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Sep 2020 11:30:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment