Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35884 )
Change subject: soc/intel/Kconfig: Move MMCONF_BASE_ADDRESS out of a common place
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG@10
PS1, Line 10: This requires soc/intel target to
: explicitly set this in the SOC dir
I see the sanity, but don't follow conclusion, why is it require by
"this"?
https://review.coreboot.org/c/coreboot/+/35884/1//COMMIT_MSG@12
PS1, Line 12: wrong
How can it be wrong? does the FSP binary depend on a specific
location?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcfea1718cc36ae16b491604786c26c6ed320f06
Gerrit-Change-Number: 35884
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 08 Oct 2019 12:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment