[coreboot-gerrit] Change in coreboot[master]: soc/intel/xeon_sp: Move set_bios_init_completion()

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47172 )

Change subject: soc/intel/xeon_sp: Move set_bios_init_completion()
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47172/1/src/soc/intel/xeon_sp/util.... 
File src/soc/intel/xeon_sp/util.c:

https://review.coreboot.org/c/coreboot/+/47172/1/src/soc/intel/xeon_sp/util.... 
PS1, Line 303: 			die("BIOS PCU Misc Config Read timed out.\n");
> why is die() called here? does something super bad going to happe when continuing here?

i guess that gets into the discussion if there is a reason to continue if it fails. I don't know as this was just a de-duplication patch.