EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32242 )
Change subject: mb/google/sarien: Reserve gpio pins for D3 cold control
......................................................................
Patch Set 6:
(2 comments)
All mistakes are fixed. Please help review it, thx.
https://review.coreboot.org/#/c/32242/2/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/gpio.c:
https://review.coreboot.org/#/c/32242/2/src/mainboard/google/sarien/variants...
PS2, Line 200: */
Please add a space before */.
Done
https://review.coreboot.org/#/c/32242/5/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/gpio.c:
https://review.coreboot.org/#/c/32242/5/src/mainboard/google/sarien/variants...
PS5, Line 200: GPP_H13
oops should be H12.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32242
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4245be8d77c015e56df7b1d53ef82722c51d656
Gerrit-Change-Number: 32242
Gerrit-PatchSet: 6
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 10 Apr 2019 16:17:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment
