Attention is currently required from: Nico Huber, Martin Roth, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51340 )
Change subject: mainboard: Drop invalid `VGA_BIOS_FILE` defaults
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/lenovo/x220/Kconfig:
https://review.coreboot.org/c/coreboot/+/51340/comment/70177e9a_352dec1c
PS4, Line 73: # FIXME: x1 with i3 cpu may also use "8086,0116"
is that intended?
Yes, I purposefully kept this comment as it still applies. I simply moved it from `VGA_BIOS_FILE` to `VGA_BIOS_ID` and adjusted it accordingly (replacing "pci8086,0116.rom" with "8086,0116").
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b5dfba035a42d7943f270f95fb7d32b285584d2
Gerrit-Change-Number: 51340
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 15 Oct 2021 07:57:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment