[coreboot-gerrit] Change in ...coreboot[master]: mb/lenovo/x131e: devicetree updates

[James Ye (Code Review)]

James Ye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31066 )

Change subject: mb/lenovo/x131e: devicetree updates
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31066/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31066/1//COMMIT_MSG@10 
PS1, Line 10:
> Please elaborate, how you tested this. […]

Unfortunately I can't test that mSATA works. This change brings x131e in line with google/stout, which AFAIK uses the mSATA slot.

I have tested that the slot being enabled but unpopulated doesn't cause issues. If this isn't good enough, then I'll revert the mSATA change.

I also can't test that WWAN detection completely works, but it does correctly detect the non-presence of a card. This change is according to the schematic, so I'm more confident it works.