View Change
1 comment:
Commit Message:
Patch Set #1, Line 10:
Please elaborate, how you tested this. […]
Unfortunately I can't test that mSATA works. This change brings x131e in line with google/stout, which AFAIK uses the mSATA slot.
I have tested that the slot being enabled but unpopulated doesn't cause issues. If this isn't good enough, then I'll revert the mSATA change.
I also can't test that WWAN detection completely works, but it does correctly detect the non-presence of a card. This change is according to the schematic, so I'm more confident it works.
To view, visit change 31066. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a
Gerrit-Change-Number: 31066
Gerrit-PatchSet: 1
Gerrit-Owner: James Ye <jye836@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: James Ye <jye836@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 24 Jan 2019 11:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment