build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46402 )
Change subject: soc/mediatek/mt8192: devapc: add basic dapc drivers
......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46402/15/src/soc/mediatek/mt8192/de...
File src/soc/mediatek/mt8192/devapc.c:
https://review.coreboot.org/c/coreboot/+/46402/15/src/soc/mediatek/mt8192/de...
PS15, Line 14: write32((void*)MAS_SEC, val);
"(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/46402/15/src/soc/mediatek/mt8192/de...
PS15, Line 16: if (read32((const void*)MAS_SEC) != val)
"(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/46402/15/src/soc/mediatek/mt8192/de...
PS15, Line 25: write32((void*)AO_APC_CON, 0x1);
"(foo*)" should be "(foo *)"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46402
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ad47c86b88047c76854a6f8a67b251b6a9d4013
Gerrit-Change-Number: 46402
Gerrit-PatchSet: 15
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Assignee: Nina-CM Wu
nina-cm.wu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Nina-CM Wu
nina-cm.wu@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 29 Oct 2020 11:59:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment