Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38860 )
Change subject: mb/google/hatch: Create palkia variant ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/palkia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 121: register "generic.reset_gpio" = : "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" : register "generic.reset_delay_ms" = "120" : register "generic.reset_off_delay_ms" = "1"
We do use GPP_D15 for touchscreen reset control .
From the schematics, it is not used. Please attach the schematics you see in the issue and point out the pin connection.
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 137: chip drivers/generic/gpio_keys : register "name" = ""PENH"" : register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" : register "key.wake" = "GPE0_DW0_08" : register "key.wakeup_event_action" = "EV_ACT_ASSERTED" : register "key.dev_name" = ""EJCT"" : register "key.linux_code" = "SW_PEN_INSERTED" : register "key.linux_input_type" = "EV_SW" : register "key.label" = ""pen_eject"" : device generic 0 on end : end
We plan to support touch pen . […]
Double check with device pm, we won't support the pen garage.
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 157: register "generic.reset_gpio" = : "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" : register "generic.reset_delay_ms" = "120" : register "generic.reset_off_delay_ms" = "1"
We do use GPP_D15 for touchscreen reset control .
Same as above.
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/palkia/ramstage.c:
PS2: Remove this file, i don't think we need this.