Attention is currently required from: Cliff Huang, Lance Zhao, Martin L Roth, Tim Wawrzynczak.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80007?usp=email )
Change subject: acpi: Reformat C files with clang-format v16 ......................................................................
Patch Set 2:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/80007/comment/91158f45_4f19783b : PS1, Line 100: xsdt->header
it was pointed out to me that this wrapping looks like regular next-level indentation and argued tha […]
[to continue the discussion here]
I've always done it this way and seen other people do it like this on pretty much every patch I worked on (if they bother to pay special attention to alignment at all). I've almost never seen double-indent in coreboot, only in special cases where there's really a risk of confusion (e.g. if you continue an if(), while() or for() statement then there's actually an indented body below which you need to differentiate from the continuation line; but those are notably shorter than 8 characters so aligning to the parenthesis is also a good alternative to provide sufficient visual distinction there).
I think the parenthesis align is very important for readability in more complicated cases (with nested parenthesis), and I don't think it does any harm in cases like this, so I'd strongly prefer we keep it.