Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45095 )
Change subject: soc/amd/picasso: Move sd_emmc_config into emmc_config struct
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45095/1/src/soc/amd/picasso/fsp_par...
File src/soc/amd/picasso/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45095/1/src/soc/amd/picasso/fsp_par...
PS1, Line 17: SD_DISABLE
Outside the scope of this patch but it looks like we should move these definitions from soc/ to vc// […]
Isolating oneself from vc and its churn. The compiler is happy enough to collapse things when they line up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b57d651ab44d6c1cad661d620bffd4207dfebd4
Gerrit-Change-Number: 45095
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Sep 2020 19:04:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment