Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37783 )
Change subject: soc/intel/tigerlake: Update chip files
......................................................................
Patch Set 19: Code-Review+1
Patch Set 16:
Patch Set 16:
Patch Set 16:
i believe u can split this CL into 2 parts
- chip.c and .h update as per FSP UPD filling requirements
- Update PCI B:D:F as per EDS.
No need to club both into one
Originally we tried to split but can't avoid auto build failure JSL as pci_dev.h and chip.c has dependency: PCH_DEVFN_GSPI3
Should we split chip.h and chip.c without PCH_DEVFN_GSPI3 change in chip.c and pci_dev.h and chip.c with PCH_DEVFN_GSPI3?
Split patch according to feedback.
- chip.c and chip.h
- pci_dev.h and chip.c including new PCI dev(GSPI3)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1518a7ffa69079fe82232afe229d9e1ffe29067
Gerrit-Change-Number: 37783
Gerrit-PatchSet: 19
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Jan 2020 07:29:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment