Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner.
Taniya Das has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56587 )
Change subject: sc7180: Cleanups for drivers with common clock
......................................................................
Patch Set 2:
(1 comment)
File src/soc/qualcomm/sc7180/display/dsi_phy.c:
https://review.coreboot.org/c/coreboot/+/56587/comment/b611355f_c5e8acdc
PS1, Line 725: .clk_div = 1, .source_div = 2},
This should probably be explained in the commit message. I don't think that it's very obvious. […]
This should probably be explained in the commit message. I don't think that it's very obvious.
Sure, will add this in the commit message.
Also, does this mean that if this CL lands and the common clock CL doesn't land that the trogdor display clock will not be configured correctly?
Yes, we need the common driver and this change to be merged together.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56587
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic334fd0d43e5b4b1e43a27d5db7665f0bc151d66
Gerrit-Change-Number: 56587
Gerrit-PatchSet: 2
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Taniya Das
tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 28 Jul 2021 02:25:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Taniya Das
tdas@codeaurora.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment