Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38856 )
Change subject: mb/google/dedede: Add EMMC configuration
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38856/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38856/1/src/mainboard/google/dedede...
PS1, Line 72: Disable
Just curious: Do you intend to enable this later on?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38856
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic27c68f4622eec5b2930dc38186b82d895d3f67c
Gerrit-Change-Number: 38856
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Tue, 18 Feb 2020 00:42:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment