Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37760 )
Change subject: bootblock: Support normal/fallback mechanism again
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37760/2/src/arch/x86/bootblock_norm...
File src/arch/x86/bootblock_normal.c:
https://review.coreboot.org/c/coreboot/+/37760/2/src/arch/x86/bootblock_norm...
PS2, Line 15: pc80/mc146818rtc.h
why please ?
for do_normal_boot()
And yes, there is more work to be done here, see <fallback.h>.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7395e62f6682f4ef123da10ac125127a57711ec6
Gerrit-Change-Number: 37760
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Denis 'GNUtoo' Carikli
GNUtoo@cyberdimension.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 16 Dec 2019 20:20:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment