Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44343 )
Change subject: mb/google/zork: Add variant.c to align with dalboz reference board ......................................................................
Patch Set 1:
(4 comments)
I had added comments this morning, but did not hit submit before.
https://review.coreboot.org/c/coreboot/+/44343/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44343/1//COMMIT_MSG@7 PS1, Line 7: Add variant.c to align with dalboz reference board What is the motivation behind doing this? Some of the changes in variant.c for dalboz are used for supporting older revisions of the board (i.e. older schematics) which I don't think apply to dirinboz.
https://review.coreboot.org/c/coreboot/+/44343/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/dirinboz/variant.c:
https://review.coreboot.org/c/coreboot/+/44343/1/src/mainboard/google/zork/v... PS1, Line 60: audio on older board versions I don't think this applies to dirinboz. Entire code from line 12-line 105 should be dropped.
https://review.coreboot.org/c/coreboot/+/44343/1/src/mainboard/google/zork/v... PS1, Line 117: board_sku == 0x5A80000C || board_sku == 0x5A800003 || board_sku == CROS_SKU_UNKNOWN Zork is moving away from using SKU ID to FW_CONFIG. Is this really correct for dirinboz?
https://review.coreboot.org/c/coreboot/+/44343/1/src/mainboard/google/zork/v... PS1, Line 205: (board_sku == 0x5A80000A) || (board_sku == 0x5A80000D) || (board_sku == 0x5A800001) All these SKU IDs are specific to Dalboz. Also, zork is moving to using FW_CONFIG instead of SKU IDs.