Attention is currently required from: Arthur Heymans, Tristan Corrick, Angel Pons, Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59316 )
Change subject: cpu/intel/model_206ax: Remove fake lapic device
......................................................................
Patch Set 20: Code-Review+2
(1 comment)
File src/cpu/intel/model_206ax/acpi.c:
https://review.coreboot.org/c/coreboot/+/59316/comment/51630d5f_3d975319
PS18, Line 100: struct cpu_intel_model_206ax_config *conf = dev->bus->dev->chip_info;
Could any of the pointers be NULL? It would be nice to check them just in case. […]
Toplevel chip_info would be a pointer to different type of struct, northbridge_intel_sandybridge_config, though?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59316
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3b1c4ca027e2905535e137691c3e3e60417dbf3
Gerrit-Change-Number: 59316
Gerrit-PatchSet: 20
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 01 Dec 2022 06:20:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment