Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34257 )
Change subject: cpu/x86: Define INSTALL_SMM option
......................................................................
Patch Set 1:
Three scenarios to consider:
a) INSTALL_SMM=y, HAVE_SMI_HANDLER=y
Current (unfortunate) situation. Build and install smm -class. Let MP init raise SMIs and do its job.
b) INSTALL_SMM=n, HAVE_SMI_HANDLER=y
Don't build smm -class.
Absolute minimal resident SMM may be installed, like asm inline "rsm"?
Let MP init raise SMIs to relocate SMM stacks?
On entry to payload, SMRAM can be locked or left unlocked.
c) INSTALL_SMM=n, HAVE_SMI_HANDLER=n
Not possible for MP init to raise SMIs.
See CB:34152 and CB:34158 what is required on source level.
Little benefits in comparison to b) above?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34257
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe827193527b7e16a3360b92bc0be25ceec8d1e6
Gerrit-Change-Number: 34257
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 12 Jul 2019 06:41:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment