Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36664 )
Change subject: x86/tsc: Only call tsc_freq_mhz once to init clock
......................................................................
Patch Set 1:
tsc_freq_mhz() function can only return 0 in below cases
1. CPUID 15h not supported
2. CPUID 16h not supported
3. CPUID 15h is returning 0 in core_crystal_nominal_freq_khz
if that would have the case then why its only happening 2nd cold boot and not always ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36664
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e9edafa3007568e8d27e3c19c9fd6fa7637786c
Gerrit-Change-Number: 36664
Gerrit-PatchSet: 1
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Thu, 14 Nov 2019 05:08:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment