Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47396 )
Change subject: soc/intel/tigerlake: Check TBT & TCSS ports for wake events
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47396/1/src/soc/intel/tigerlake/elo...
File src/soc/intel/tigerlake/elog.c:
https://review.coreboot.org/c/coreboot/+/47396/1/src/soc/intel/tigerlake/elo...
PS1, Line 86: SA_DEVFN_TCSS_XHCI
it could be adapted to take in a device instead of assuming PCH
I think that makes sense. It looks like both north and south XHCI have the exact same structure. So as long as you pass in the device and port register map, the same driver should be able to handle it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47396
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9904c3c01ea85fcd83218fcfeaa4378b07c1463
Gerrit-Change-Number: 47396
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 10 Nov 2020 22:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment