John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33150 )
Change subject: src/drivers/intel: Avoid NULL pointer dereference
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33150/3/src/drivers/intel/fsp1_1/car.c
File src/drivers/intel/fsp1_1/car.c:
https://review.coreboot.org/#/c/33150/3/src/drivers/intel/fsp1_1/car.c@176
PS3, Line 176: return;
return or rather die()? if the fsp isn't included, it won't get very far anyway
Updated with die() instead of return.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6853e5302c87d9ffe52b942f067be56f6e77406
Gerrit-Change-Number: 33150
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Comment-Date: Tue, 04 Jun 2019 18:34:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment