Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73428 )
Change subject: soc/amd/common/block/acpi/cpu_power_state: add get_cstate_info helper
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/common/block/acpi/cpu_power_state.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171520):
https://review.coreboot.org/c/coreboot/+/73428/comment/d0b43b8a_67d0abee
PS4, Line 60: for (i = 0; i < cstate_count; i++) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73428
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c36c1d604ced349c609882b9d9fe84d5f726a8d
Gerrit-Change-Number: 73428
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 07 Mar 2023 02:14:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment