build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35411 )
Change subject: cpu/allwinner: Prepend the BOOT0 header to the bootblock.bin ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35411/1/util/arm_boot_tools/mksunxi... File util/arm_boot_tools/mksunxiboot/mksunxiboot.c:
https://review.coreboot.org/c/coreboot/+/35411/1/util/arm_boot_tools/mksunxi... PS1, Line 65: static int fill_check_sum(struct boot_file_head *hdr, const void *boot_code, size_t load_size) line over 80 characters
https://review.coreboot.org/c/coreboot/+/35411/1/util/arm_boot_tools/mksunxi... PS1, Line 91: for (i = 0; i < hdr->length - load_size- HEADER_SIZE; i +=4) need consistent spacing around '-' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/35411/1/util/arm_boot_tools/mksunxi... PS1, Line 91: for (i = 0; i < hdr->length - load_size- HEADER_SIZE; i +=4) spaces required around that '+=' (ctx:WxV)