Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33162 )
Change subject: cpu: Add option to disable CPU AES ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/#/c/33162/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33162/7//COMMIT_MSG@9 PS7, Line 9: option(CPU_DISABLE_HW_AES) Please add a space before the (.
https://review.coreboot.org/#/c/33162/7//COMMIT_MSG@9 PS7, Line 9: Added Present tense: Add
https://review.coreboot.org/#/c/33162/7//COMMIT_MSG@13 PS7, Line 13: Register(MSR) Please add a space before (.
https://review.coreboot.org/#/c/33162/7//COMMIT_MSG@15 PS7, Line 15: Please add the motivation, why CPU AES should be disabled.
https://review.coreboot.org/#/c/33162/7/src/cpu/Kconfig File src/cpu/Kconfig:
https://review.coreboot.org/#/c/33162/7/src/cpu/Kconfig@231 PS7, Line 231: Check this in to disable AES cryptographic hardware acceleration on the CPU. Please check the indentation (see above).
Please explain to the user, why this would be useful.