mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
The Kconfig option seems useless.
Which option, and why useless?
I assume CONFIG_MULTIPLE_VGA_ADAPTERS? and have to say, I never understood it either. It doesn't seem to do anything AMD specific so why do other platforms don't need it? IMHO, we should get rid of that option, first, or document what it does if it does some- thing useful.
$ git grep create_vga_resource .. create_vga_resource(dev, nodeid); //TODO: do we need this? ..
Does not rise much confidence...
Even if this option does not seem too useful to you at the moment: it already exists and has a nice name, so we could take it over by writing useful code for it.