Attention is currently required from: Subrata Banik, Terry Chen, Tim Wawrzynczak, Nick Vaccaro, Franklin Lin.
Paz Zcharya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68868 )
Change subject: mb/google/brya: Update Crota's ELAN touchscreen delay to 150 ms
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/crota/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68868/comment/c5bf41cb_1eef071b
PS6, Line 225: 150
do we even need 150ms, on Rex, the reset delay with 20ms is meeting the spec.
Spec requires 150 ms minimum delay in between pulling RESET high and sending the first i2c commands. However, in practice, the device (I assume OS) doesn't send commands until about ~2 seconds after the power-on sequence (measured with scope by ELAN).
So the short answer is that we can have 0 delay as long as things don't change. However, if all of a sudden OS' flow changes and we power-on the device late / send commands early (unlikely), things might break.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68868
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17e1f7d419637f6dff4049484ce1836ad98017ea
Gerrit-Change-Number: 68868
Gerrit-PatchSet: 6
Gerrit-Owner: Paz Zcharya
pazz@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Franklin Lin
franklin_lin@wistron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Franklin Lin
franklin_lin@wistron.corp-partner.google.com
Gerrit-Comment-Date: Wed, 26 Oct 2022 13:44:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment