Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27533 )
Change subject: util/lint: Update checkpatch max line length from 80 to 96
......................................................................
Patch Set 4:
Patch Set 4:
Note that this can be done with a command line flag like Patrick did in CB:31651. That's probably the preferable way.
I'm fine with that.
Are you planning to check this in before the whole codebase is converted? I would prefer that we do both at once so we don't have inconsistent lengths everywhere.
Yes, I'm planning on doing it immediately.
- The codebase will be updated incrementally, directory by directory, not all at once. It makes sense to do this before we start updating line lengths so we don't get a slew of warnings when we update the files.
- We've decided to allow 96 characters, so let's get checkpatch to stop complaining about it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic76f9544a609f4c941902c45d5f77df0b644f6a8
Gerrit-Change-Number: 27533
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-CC: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-CC: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:44:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment