Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35757 )
Change subject: sb/intel/ibexpeak: Fix enabling HPTC ......................................................................
Patch Set 2:
(2 comments)
Is the problem also visible in the OS? Should SeaBIOS (or payloads in general) also be fixed somehow to work around firmware bugs?
https://review.coreboot.org/c/coreboot/+/35757/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35757/2//COMMIT_MSG@9 PS2, Line 9: RCBA_HPTC needs to be read back to properly work. : This fixes SeaBIOS endlessly waiting for input instead of booting the : default entry. Please do not break the line, just because the sentence ends there. If it’s a paragraph, please add a blank line between them.
https://review.coreboot.org/c/coreboot/+/35757/2/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/lpc.c:
https://review.coreboot.org/c/coreboot/+/35757/2/src/southbridge/intel/ibexp... PS2, Line 397: RCBA32(HPTC); /* Read back for it to work */ Mention SeaBIOS as an exapmle?