[coreboot-gerrit] Change in coreboot[master]: nb/via/vx900: Ensure framebuffer size is within limits

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34355 )

Change subject: nb/via/vx900: Ensure framebuffer size is within limits
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34355/3/src/northbridge/via/vx900/m... 
File src/northbridge/via/vx900/memmap.c:

https://review.coreboot.org/c/coreboot/+/34355/3/src/northbridge/via/vx900/m... 
PS3, Line 83: 	assert(size_mb != 0);
> Just did: src/include/assert.h has assert() defined as a macro. […]

If we do that and size_mb is 0, then it will get rounded up to 1 after the fb_pow stuff and then print an incorrect error message on line 94 (since the size is actually 0 and not 1). I think we should just change this to a die() here with the right message.