Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36273 )
Change subject: lib/cbmem_top: Add a common cbmem_top implementation ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36273/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36273/13//COMMIT_MSG@16 PS13, Line 16: if CONFIG_RAMSTAGE_CBMEM_TOP_ARG is not set the : same implementation as will be used as in romstage. : I think the naming of your source of cbmem top is the issue. We shouldn't be using functions named _romstage() in stages other than romstage. It just causes confusion.