Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45055 )
Change subject: soc/amd/picasso: Fix TSC frequency calculation
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45055/1/src/soc/amd/picasso/tsc_fre...
File src/soc/amd/picasso/tsc_freq.c:
https://review.coreboot.org/c/coreboot/+/45055/1/src/soc/amd/picasso/tsc_fre...
PS1, Line 29: mhz = 0;
It should not really happen. But 0 is a valid value which indicates that clock is off. […]
If it’s an condition, that shouldn’t happen, I think at least a warning or notice should be printed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe3f49c7d295e7336ee042da2b94823171b6eb55
Gerrit-Change-Number: 45055
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Sep 2020 07:51:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-MessageType: comment