Attention is currently required from: Nico Huber. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48262 )
Change subject: mb/emulation/qemu-q35: Add support for SMM_TSEG with parallel MP init ......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/emulation/qemu-q35/cpu.c:
https://review.coreboot.org/c/coreboot/+/48262/comment/e6aab16e_b82c29c0 PS8, Line 17: /* FIXME: on X86_64 the save state size is smaller than the size of the SMM stub */
I assume when the stub is compiled for X86_64? Why is this a problem?
So taking the MAX(stub size, save state size) during the mp init would work, but the smihandler save state handler is not dealing with that properly ATM. In general the SMM setup needs some work/refactoring. I thought it would be best to leave a FIXME as the compilation would fail on x86_64 and setting a larger size is quick fix (even though some things don't work then)