Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jakub Czapiga, Julius Werner, Nick Vaccaro, Nick Vaccaro, Yu-Ping Wu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78076?usp=email )
Change subject: {lib, ec/google}: Add weak implementation for get_lid_switch() ......................................................................
Patch Set 2:
(2 comments)
File src/ec/google/chromeec/switches.c:
https://review.coreboot.org/c/coreboot/+/78076/comment/40b67142_e0664fc8 : PS1, Line 8: {
Since this is now usually called twice in ramstage (once for lb_gpios and once by the GMA driver) it […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/78076/comment/cbad61e2_6371788b : PS1, Line 9: if (!CONFIG(VBOOT_LID_SWITCH))
Oh, right because Chromeboxes still have ECs. Okay that makes sense. I wonder if we should flip it around though (or just make it `default y`). It seems cumbersome that every laptop mainboard needs to select this explicitly when 90% of our boards are laptops.
that is valid point, ideally VBOOT_LID_SWITCH should be default y if VBOOT is enabled and then chromeboxes and bases can overrides that to N.
my initial understanding that only chromeos devices are using vboot and we should be enable VBOOT_LID_SWITCH enable by default. But looks like there are many board outside chromeos selects VBOOT but eventually doesn't wanted to keep VBOOT_LID_SWITCH default enable aka implement get_lid_status() API.
I have attempted CB:78207 which apparently much widespread than i originally thought.